Skip to content

meta: add ethan.arrowood@vercel.com to mailmap#50491

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Ethan-Arrowood:fix-ethan-arrowood-mailmap
Oct 31, 2023
Merged

meta: add ethan.arrowood@vercel.com to mailmap#50491
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Ethan-Arrowood:fix-ethan-arrowood-mailmap

Conversation

@Ethan-Arrowood
Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood commented Oct 31, 2023

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 31, 2023
@H4ad H4ad added the fast-track PRs that do not need to wait for 72 hours to land. label Oct 31, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @H4ad. Please 👍 to approve.

@Ethan-Arrowood Ethan-Arrowood self-assigned this Oct 31, 2023
@Ethan-Arrowood
Copy link
Contributor Author

Even for something like this I should wait for a completely green CI, right?

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 31, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 31, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/50491 ✔ Done loading data for nodejs/node/pull/50491 ----------------------------------- PR info ------------------------------------ Title meta: add ethan.arrowood@vercel.com to mailmap (#50491) Author Ethan Arrowood (@Ethan-Arrowood) Branch Ethan-Arrowood:fix-ethan-arrowood-mailmap -> nodejs:main Labels meta, fast-track Commits 1 - meta: add ethan.arrowood@vercel.com to mailmap Committers 1 - Ethan Arrowood PR-URL: https://github.com/nodejs/node/pull/50491 Fixes: https://github.com/nodejs/node/pull/50470 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50491 Fixes: https://github.com/nodejs/node/pull/50470 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 31 Oct 2023 15:31:25 GMT ✔ Approvals: 3 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/50491#pullrequestreview-1706851198 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/50491#pullrequestreview-1706893547 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/50491#pullrequestreview-1707078417 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 50491 From https://github.com/nodejs/node * branch refs/pull/50491/merge -> FETCH_HEAD ✔ Fetched commits as 0899bee48c64..bae01607c2fe -------------------------------------------------------------------------------- [main 364b054940] meta: add ethan.arrowood@vercel.com to mailmap Author: Ethan Arrowood Date: Tue Oct 31 09:30:45 2023 -0600 1 file changed, 3 insertions(+), 2 deletions(-) ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- meta: add ethan.arrowood@vercel.com to mailmap 

PR-URL: #50491
Fixes: #50470
Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: Luigi Pinca luigipinca@gmail.com

[main 2fe30372ce] meta: add ethan.arrowood@vercel.com to mailmap
Author: Ethan Arrowood ethan.arrowood@vercel.com
Date: Tue Oct 31 09:30:45 2023 -0600
1 file changed, 3 insertions(+), 2 deletions(-)
✖ 2fe30372ce79ebe986bbcca34c05ef74d7da539b
✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
✖ 2:7 Pull request URL must reference a comment or discussion. fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length

ℹ Please fix the commit message and try again.
Please manually ammend the commit message, by running
git commit --amend
Once commit message is fixed, finish the landing command running
git node land --continue

https://github.com/nodejs/node/actions/runs/6711475875

@richardlau richardlau added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 31, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 31, 2023
@nodejs-github-bot nodejs-github-bot merged commit 2a49973 into nodejs:main Oct 31, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 2a49973

@Ethan-Arrowood Ethan-Arrowood deleted the fix-ethan-arrowood-mailmap branch October 31, 2023 19:59
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
PR-URL: nodejs#50491 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Nov 9, 2023
PR-URL: nodejs#50491 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
PR-URL: #50491 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Nov 14, 2023
PR-URL: #50491 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
PR-URL: #50491 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs that do not need to wait for 72 hours to land. meta Issues and PRs related to the general management of the project.

6 participants