tls: use SSL_get_peer_tmp_key#53366
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Jun 13, 2024
Merged
Conversation
tniessen added tls 
Collaborator
| Review requested:
|
nodejs-github-bot added c++ 
panva approved these changes Jun 6, 2024
pimterry approved these changes Jun 6, 2024
github-actions bot removed the request-ci This comment was marked as outdated.
This comment was marked as outdated.
tniessen force-pushed the ssl-get-peer-tmp-key branch from 935360e to 95420da Compare 
richardlau approved these changes Jun 6, 2024
tniessen added the author ready 
github-actions bot removed the request-ci Collaborator
Member Author
| Windows CI is failing because... Windows. |
lpinca approved these changes Jun 6, 2024
anonrig approved these changes Jun 7, 2024
Both OpenSSL 1.1.1 and 3.x support SSL_get_peer_tmp_key as a replacement for SSL_get_server_tmp_key. While the old function name still exists as an alias, it does not accurately reflect the function's behavior (anymore). Hence, use the new function name here.
tniessen force-pushed the ssl-get-peer-tmp-key branch from 95420da to 80105b0 Compare github-actions bot removed the request-ci This comment has been minimized.
This comment has been minimized.
tniessen removed the author ready This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
tniessen added the commit-queue nodejs-github-bot removed the commit-queue nodejs-github-bot added the commit-queue-failed Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/53366 ✔ Done loading data for nodejs/node/pull/53366 ----------------------------------- PR info ------------------------------------ Title tls: use SSL_get_peer_tmp_key (#53366) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:ssl-get-peer-tmp-key -> nodejs:main Labels tls, crypto, c++, openssl, needs-ci Commits 1 - tls: use SSL_get_peer_tmp_key Committers 1 - Tobias Nießen PR-URL: https://github.com/nodejs/node/pull/53366 Reviewed-By: Filip Skokan Reviewed-By: Tim Perry Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53366 Reviewed-By: Filip Skokan Reviewed-By: Tim Perry Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - tls: use SSL_get_peer_tmp_key ℹ This PR was created on Thu, 06 Jun 2024 14:41:06 GMT ✔ Approvals: 5 ✔ - Filip Skokan (@panva): https://github.com/nodejs/node/pull/53366#pullrequestreview-2102193493 ✔ - Tim Perry (@pimterry): https://github.com/nodejs/node/pull/53366#pullrequestreview-2102209818 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/53366#pullrequestreview-2102272801 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53366#pullrequestreview-2103101790 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/53366#pullrequestreview-2103961048 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-06-10T21:32:13Z: https://ci.nodejs.org/job/node-test-pull-request/59718/ - Querying data for job/node-test-pull-request/59718/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9501496421 |
richardlau approved these changes Jun 13, 2024
richardlau added commit-queue nodejs-github-bot removed the commit-queue Collaborator
| Landed in 786464d |
targos pushed a commit that referenced this pull request Jun 20, 2024
Both OpenSSL 1.1.1 and 3.x support SSL_get_peer_tmp_key as a replacement for SSL_get_server_tmp_key. While the old function name still exists as an alias, it does not accurately reflect the function's behavior (anymore). Hence, use the new function name here. PR-URL: #53366 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
sophoniie pushed a commit to sophoniie/node that referenced this pull request Jun 20, 2024
Both OpenSSL 1.1.1 and 3.x support SSL_get_peer_tmp_key as a replacement for SSL_get_server_tmp_key. While the old function name still exists as an alias, it does not accurately reflect the function's behavior (anymore). Hence, use the new function name here. PR-URL: nodejs#53366 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
Both OpenSSL 1.1.1 and 3.x support SSL_get_peer_tmp_key as a replacement for SSL_get_server_tmp_key. While the old function name still exists as an alias, it does not accurately reflect the function's behavior (anymore). Hence, use the new function name here. PR-URL: nodejs#53366 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
Both OpenSSL 1.1.1 and 3.x support SSL_get_peer_tmp_key as a replacement for SSL_get_server_tmp_key. While the old function name still exists as an alias, it does not accurately reflect the function's behavior (anymore). Hence, use the new function name here. PR-URL: #53366 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
Both OpenSSL 1.1.1 and 3.x support SSL_get_peer_tmp_key as a replacement for SSL_get_server_tmp_key. While the old function name still exists as an alias, it does not accurately reflect the function's behavior (anymore). Hence, use the new function name here. PR-URL: #53366 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Merged
codebytere added a commit to electron/electron that referenced this pull request Jul 25, 2024
codebytere added a commit to electron/electron that referenced this pull request Jul 26, 2024
jkleinsc pushed a commit to electron/electron that referenced this pull request Jul 26, 2024
* chore: bump node in DEPS to v20.16.0 * test: skip unstable shadow realm gc tests nodejs/node#52855 * test: extend env for `test-node-output-errors` nodejs/node#53535 * src: fix typo in env.cc nodejs/node#53418 * src: reset `process.versions` during pre-execution nodejs/node#53444 * chore: fixup patch indices * src,permission: --allow-wasi & prevent WASI exec nodejs/node#53124 * tls: use SSL_get_peer_tmp_key nodejs/node#53366 * deps: update c-ares to 1.29.0 nodejs/node#53155 * src: account for OpenSSL unexpected version * crypto: fix propagation of "memory limit exceeded" nodejs/node#53300 * process: add process.getBuiltinModule(id) nodejs/node#52762 * windows 32bit: config change callback needs to be stdcall c-ares/c-ares@8f265c9 * fix: building with UNICODE c-ares/c-ares#802 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both OpenSSL 1.1.1 and 3.x support
SSL_get_peer_tmp_keyas a replacement forSSL_get_server_tmp_key. While the old function name still exists as an alias, it does not accurately reflect the function's behavior (anymore). Hence, use the new function name here.