[v20.x backport] stream: implement min option for ReadableStreamBYOBReader.read#54044
Closed
MattiasBuelens wants to merge 2 commits intonodejs:v20.x-stagingfrom
Closed
[v20.x backport] stream: implement min option for ReadableStreamBYOBReader.read#54044MattiasBuelens wants to merge 2 commits intonodejs:v20.x-stagingfrom
min option for ReadableStreamBYOBReader.read#54044MattiasBuelens wants to merge 2 commits intonodejs:v20.x-stagingfrom
Conversation
Collaborator
| Review requested:
|
nodejs-github-bot added lib / src 
PR-URL: nodejs#50888 Backport-PR-URL: nodejs#54044 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
MattiasBuelens force-pushed the backport-50888-to-v20.x branch from 33cc538 to 22340d9 Compare Collaborator
Collaborator
benjamingr approved these changes Jul 27, 2024
MattiasBuelens added the author ready 
MattiasBuelens commented Jul 27, 2024
MattiasBuelens removed the author ready 
Member
| cc @nodejs/releasers @RafaelGSS can you include this in the next v20? |
MattiasBuelens added the author ready 
Member
Yes, whoever takes the lead on the next v20 release will merge this PR with staging. |
aymen94 approved these changes Aug 7, 2024
Member
| Landed in 4a3ecbf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #50888 to v20.x.