src: fix kill signal on Windows#55514
Merged
nodejs-github-bot merged 4 commits intonodejs:mainfrom Nov 20, 2024
Merged
Conversation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As stated in the documentation of Node.js, the
signalparameter of child processkillfunction is ignored.However, when we execute
spawn(process.execPath, ['-v']).kill('SIGHUP');, it throws an exception with the codeENOSYS. This is not consistent with the documentation.I've looked at the implementation in libuv and have seen that only four signal types are supported to kill a process on Windows.
This PR fixes this issue by changing the signal to
SIGKILLif it differs fromSIGQUIT,SIGTERM,SIGKILL, andSIGINT. In addition, there is a slight change in the documentation to clarify thesignalparameter.Fixes: #42923