add autocompletable header types#3462
Merged
KhafraDev merged 1 commit intonodejs:mainfrom Aug 16, 2024
Merged
Conversation
Member Author
| The types only work for the object param of the constructor. It would be possible to add support for the other methods, but would require a generic which would interfere with the DOM types. |
KhafraDev commented Aug 15, 2024
| } | ||
| | ||
| export type HeadersInit = string[][] | Record<string, string | ReadonlyArray<string>> | Headers | ||
| export type HeadersInit = [string, string][] | HeaderRecord | Headers |
Member Author
There was a problem hiding this comment.
ReadonlyArray is just not correct. If we were to follow the logic in the PR that added it, the type should be any.
Any array pair that doesn't contain exactly 2 strings throws an error too, so string[][] is not strict enough.
Uzlopak reviewed Aug 15, 2024
Uzlopak reviewed Aug 15, 2024
Uzlopak reviewed Aug 15, 2024
Uzlopak reviewed Aug 15, 2024
Uzlopak previously requested changes Aug 15, 2024
Contributor
Uzlopak left a comment
Uzlopak left a comment There was a problem hiding this comment.
We should discuss this a little bit before merging.
Merged
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the header keys were taken from MDN and the values for the content-type header were taken from hono