fix: add jsdoc and do minor changes in utils.js#3550
Merged
Uzlopak merged 1 commit intonodejs:mainfrom Sep 5, 2024
Merged
Conversation
Uzlopak commented Sep 4, 2024
| */ | ||
| function parseKeepAliveTimeout (val) { | ||
| const m = val.toString().match(KEEPALIVE_TIMEOUT_EXPR) | ||
| const m = val.match(KEEPALIVE_TIMEOUT_EXPR) |
Contributor Author
There was a problem hiding this comment.
parseKeepAliveTimeout gets according to my analysis always a string, so we can avoid the toString() call
Uzlopak commented Sep 4, 2024
| function parseRawHeaders (headers) { | ||
| const len = headers.length | ||
| const ret = new Array(len) | ||
| const headersLength = headers.length |
Contributor Author
There was a problem hiding this comment.
we can reuse the headersLength variable for the for loop
Uzlopak commented Sep 4, 2024
| if (range == null || range === '') return { start: 0, end: null, size: null } | ||
| | ||
| const m = range ? range.match(/^bytes (\d+)-(\d+)\/(\d+)?$/) : null | ||
| const m = range ? range.match(rangeHeaderRegex) : null |
Contributor Author
There was a problem hiding this comment.
extracted the range regex for better perf
Uzlopak commented Sep 4, 2024
| function removeAllListeners (obj) { | ||
| for (const [name, listener] of obj[kListeners] ?? []) { | ||
| obj.removeListener(name, listener) | ||
| if (obj[kListeners] != null) { |
Contributor Author
There was a problem hiding this comment.
if obj[kListeners] is not null or undefined, then we know it is an array, so only do the steps if we have somthing set.
metcoder95 approved these changes Sep 5, 2024
Merged
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add jsdoc to the utils.js file to improve typings in other places.
also made minor changes, which i will comment