Skip to content

feat: jsdoc and minor optimizations in client-h1.js#3551

Merged
mcollina merged 1 commit intonodejs:mainfrom
Uzlopak:client-h1-jsdoc
Sep 7, 2024
Merged

feat: jsdoc and minor optimizations in client-h1.js#3551
mcollina merged 1 commit intonodejs:mainfrom
Uzlopak:client-h1-jsdoc

Conversation

@Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Sep 5, 2024

No description provided.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit a6dac31 into nodejs:main Sep 7, 2024
@Uzlopak Uzlopak deleted the client-h1-jsdoc branch September 7, 2024 07:44
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

The backport to v6.x failed:

The process '/usr/bin/git' failed with exit code 1 

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub git fetch # Create a new working tree git worktree add .worktrees/backport-v6.x v6.x # Navigate to the new working tree cd .worktrees/backport-v6.x # Create a new branch git switch --create backport-3551-to-v6.x # Cherry-pick the merged commit of this pull request and resolve the conflicts git cherry-pick -x --mainline 1 a6dac3149c505b58d2e6d068b97f4dc993da55f0 # Push it to GitHub git push --set-upstream origin backport-3551-to-v6.x # Go back to the original working tree cd ../.. # Delete the working tree git worktree remove .worktrees/backport-v6.x

Then, create a pull request where the base branch is v6.x and the compare/head branch is backport-3551-to-v6.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants