Conversation
Uzlopak force-pushed the jsdoc-readable branch from ec1802e to 8a3a860 Compare 
Uzlopak commented Sep 8, 2024
Comment on lines +283 to 299
| if (signal) { | ||
| const onAbort = () => { | ||
| this.destroy(signal.reason ?? new AbortError()) | ||
| } | ||
| signal.addEventListener('abort', onAbort) | ||
| this | ||
| .on('close', function () { | ||
| signal.removeEventListener('abort', onAbort) | ||
| if (signal.aborted) { | ||
| reject(signal.reason ?? new AbortError()) | ||
| } else { | ||
| resolve(null) | ||
| } | ||
| }) | ||
| } else { | ||
| this.on('close', resolve) | ||
| } |
Contributor Author
There was a problem hiding this comment.
reorderering so that we only do signal specific stuff like creating onAbort if needed
Uzlopak commented Sep 8, 2024
ronag approved these changes Sep 8, 2024
Uzlopak commented Sep 8, 2024
Contributor Author
| @ronag |
ronag approved these changes Sep 8, 2024
Merged
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds jsdoch to readable, fixes some aspects which i will comment