Skip to content

diagnostics-channel: use not deprecated subscribe fn#3600

Merged
mcollina merged 2 commits intomainfrom
diagnostics-channel-new-format
Sep 13, 2024
Merged

diagnostics-channel: use not deprecated subscribe fn#3600
mcollina merged 2 commits intomainfrom
diagnostics-channel-new-format

Conversation

@Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Sep 13, 2024

In engines we declare that we support node >= 18.17. and the new subscribe notation is existitng since 18.7.

https://nodejs.org/api/diagnostics_channel.html#diagnostics_channelsubscribename-onmessage

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit c773728 into main Sep 13, 2024
@Uzlopak Uzlopak deleted the diagnostics-channel-new-format branch September 13, 2024 14:45
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
This was referenced Dec 16, 2024
@github-actions github-actions bot mentioned this pull request Mar 12, 2025
@github-actions github-actions bot mentioned this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants