Merged
Conversation
szepeviktor reviewed Sep 23, 2024
| ### Return: `MockScope` | ||
| | ||
| A `MockScope` is associated with a single `MockInterceptor`. With this, we can configure the default behaviour of a intercepted reply. | ||
| A `MockScope` is associated with a single `MockInterceptor`. With this, we can configure the default behaviour of an intercepted reply. |
There was a problem hiding this comment.
@NathanBaulch I also do random PR-s with typos.
How do you spot wrong indefinite articles?
Contributor Author
There was a problem hiding this comment.
IntelliJ highlights them. I usually only fix them if the PR I'm working on isn't getting too out of hand.
There was a problem hiding this comment.
KhafraDev previously requested changes Sep 23, 2024
Member
KhafraDev left a comment
KhafraDev left a comment There was a problem hiding this comment.
Most of the changes to lib/web should be reverted.
Contributor Author
| Is |
Member
| The comments come from the various whatwg specs we implement. |
metcoder95 reviewed Sep 24, 2024
metcoder95 approved these changes Sep 25, 2024
Merged
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just thought I'd contribute some typo fixes that I stumbled on. Nothing controversial (hopefully).
Use the following command to get a quick summary of the specific corrections made:
FWIW, the top typos are: