lib: add nowAbsolute to fast timers#3749
Merged
mcollina merged 1 commit intonodejs:mainfrom Nov 18, 2024
Merged
Conversation
flakey5 commented Oct 19, 2024
7 tasks
KhafraDev reviewed Oct 19, 2024
ronag requested changes Oct 19, 2024
Member
ronag left a comment
ronag left a comment There was a problem hiding this comment.
This can't use the no stall timer.
Member
| Add another variable called fastNowAbsolute which is updated to date.now in every refresh |
ronag reviewed Oct 23, 2024
Uzlopak reviewed Oct 23, 2024
| @@ -0,0 +1,13 @@ | |||
| import { bench, group, run } from 'mitata' | |||
Contributor
There was a problem hiding this comment.
kind of trivial benchmark.
flakey5 force-pushed the flakey5/20241018/now-absolute branch from 152c924 to eb65121 Compare 
Member
| CI is very red |
Member
| Still very red |
flakey5 force-pushed the flakey5/20241018/now-absolute branch from b9d2d1a to a8238fd Compare ronag approved these changes Nov 18, 2024
Member
| This now conflicts |
Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
flakey5 force-pushed the flakey5/20241018/now-absolute branch from a8238fd to b494bf1 Compare ronag approved these changes Nov 18, 2024
Merged
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
nowAbsolutefunction to the fast timers lib that allows for fetching the approximate absolute timestamp. This is useful in places like the cache interceptor and cache stores, where we're currently callingDate.now().cc @mcollina