Merged
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Member Author
| I've opened this PR as draft with a lot of debug output, I will clean it up if this actually passes. |
ronag approved these changes Nov 14, 2024
Uzlopak reviewed Nov 14, 2024
lib/dispatcher/client-h2.js Outdated
Comment on lines +490 to +492
| // The request was aborted | ||
| if (!request.aborted) { | ||
| request.onComplete([]) |
Contributor
There was a problem hiding this comment.
I am just a little bit confused by the comment. Do you mean, The request was not aborted?
Uzlopak approved these changes Nov 14, 2024
Contributor
Uzlopak left a comment
Uzlopak left a comment There was a problem hiding this comment.
I dont see any obvious issue
LGTM
Member Author
| @Uzlopak PTAL |
Merged
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes how GOAWAY frames and user aborts are handled in HTTP/2.
In essence, we had a flaky test for a while that showed up locally on my machine after 2-3 hours of continuous runs. It's a bad race condition, which has been hard to find and a bad overlap between goaway, aborts, and manipulation of the
Clientstate from the outside.