CacheRevalidationHandler: add missing header to comment#4111
Merged
metcoder95 merged 1 commit intonodejs:mainfrom Mar 21, 2025
Merged
CacheRevalidationHandler: add missing header to comment#4111metcoder95 merged 1 commit intonodejs:mainfrom
metcoder95 merged 1 commit intonodejs:mainfrom
Conversation
Include if-not-modified as a potential header which can tell the origin we want to revlidate.
alxndrsn changed the title 
metcoder95 approved these changes Mar 21, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include if-not-modified as a potential header which can tell the origin we want to revlidate.
This relates to...
Rationale
The current comment implies that
if-modified-sinceis the only header relevant to revalidation.Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status