Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
flakey5 approved these changes May 8, 2025
Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina changed the title 
metcoder95 approved these changes May 9, 2025
caitp pushed a commit to caitp/undici that referenced this pull request May 15, 2025
* Restore cache tests Signed-off-by: Matteo Collina <hello@matteocollina.com> * fixed caching Signed-off-by: Matteo Collina <hello@matteocollina.com> * fixup Signed-off-by: Matteo Collina <hello@matteocollina.com> * fixup Signed-off-by: Matteo Collina <hello@matteocollina.com> --------- Signed-off-by: Matteo Collina <hello@matteocollina.com>
slagiewka pushed a commit to slagiewka/undici that referenced this pull request Feb 14, 2026
* Restore cache tests Signed-off-by: Matteo Collina <hello@matteocollina.com> * fixed caching Signed-off-by: Matteo Collina <hello@matteocollina.com> * fixup Signed-off-by: Matteo Collina <hello@matteocollina.com> * fixup Signed-off-by: Matteo Collina <hello@matteocollina.com> --------- Signed-off-by: Matteo Collina <hello@matteocollina.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cache tests were not being run. Restore them and add a check to prevent this situation to happen again.
Moreover, it fixes a bug in the memory storage that prevented the max-age and expiry directives to work properly.
fixes #4203