Skip to content

fix(core): preserve existing source properties in claude plugin config#34499

Merged
MaxKless merged 5 commits intomasterfrom
experimental-no-override
Feb 23, 2026
Merged

fix(core): preserve existing source properties in claude plugin config#34499
MaxKless merged 5 commits intomasterfrom
experimental-no-override

Conversation

@MaxKless
Copy link
Collaborator

Current Behavior

Running configure-ai-agents overwrites the entire source object in extraKnownMarketplaces['nx-claude-plugins'], removing any user-added properties like ref.

Expected Behavior

User-added source properties (e.g. ref) are preserved, while source and repo are always set to the correct values.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@MaxKless MaxKless requested a review from a team as a code owner February 18, 2026 16:34
@netlify
Copy link

netlify bot commented Feb 18, 2026

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit 541ea8e
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/699c327a5dee790008995819
😎 Deploy Preview https://deploy-preview-34499--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link
Contributor

nx-cloud bot commented Feb 18, 2026

View your CI Pipeline Execution ↗ for commit 541ea8e

Command Status Duration Result
nx affected --targets=lint,test,test-kt,build,e... ✅ Succeeded 44m 33s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 3m 14s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 8s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-02-23 11:46:03 UTC

@netlify
Copy link

netlify bot commented Feb 18, 2026

Deploy Preview for nx-dev ready!

Name Link
🔨 Latest commit 541ea8e
🔍 Latest deploy log https://app.netlify.com/projects/nx-dev/deploys/699c327a5dee79000899581b
😎 Deploy Preview https://deploy-preview-34499--nx-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> [Self-Healing CI Rerun]
nx-cloud[bot]

This comment was marked as outdated.

nx-cloud[bot]

This comment was marked as outdated.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> [Self-Healing CI Rerun]
nx-cloud[bot]

This comment was marked as outdated.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> [Self-Healing CI Rerun]
Copy link
Contributor

@nx-cloud nx-cloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.

Nx Cloud has identified a possible root cause for your failed CI:

Our analysis indicates this failure is due to an environment_state issue rather than the PR's code changes. The error "Gradle build daemon has been stopped: stop command received" occurred in the e2e-gradle project (not touched by this PR), while our changes only modify AI agent configuration logic in the nx package—there's no code path connecting these two areas.

No code changes were suggested for this issue.

🔂 A CI rerun has been triggered by adding an empty commit to this branch.

Nx Cloud View detailed reasoning on Nx Cloud ↗


🎓 Learn more about Self-Healing CI on nx.dev

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> [Self-Healing CI Rerun]
@MaxKless MaxKless merged commit e8633e0 into master Feb 23, 2026
23 checks passed
@MaxKless MaxKless deleted the experimental-no-override branch February 23, 2026 12:45
FrozenPandaz pushed a commit that referenced this pull request Feb 26, 2026
#34499) ## Current Behavior Running `configure-ai-agents` overwrites the entire `source` object in `extraKnownMarketplaces['nx-claude-plugins']`, removing any user-added properties like `ref`. ## Expected Behavior User-added source properties (e.g. `ref`) are preserved, while `source` and `repo` are always set to the correct values. (cherry picked from commit e8633e0)
FrozenPandaz pushed a commit that referenced this pull request Feb 26, 2026
#34499) ## Current Behavior Running `configure-ai-agents` overwrites the entire `source` object in `extraKnownMarketplaces['nx-claude-plugins']`, removing any user-added properties like `ref`. ## Expected Behavior User-added source properties (e.g. `ref`) are preserved, while `source` and `repo` are always set to the correct values. (cherry picked from commit e8633e0)
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2026

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants