Skip to content

fix(gradle): ensure that atomized task targets have dependsOn#34611

Merged
lourw merged 2 commits intomasterfrom
lourw/add-depends-on-for-test-ci-tasks
Feb 25, 2026
Merged

fix(gradle): ensure that atomized task targets have dependsOn#34611
lourw merged 2 commits intomasterfrom
lourw/add-depends-on-for-test-ci-tasks

Conversation

@lourw
Copy link
Contributor

@lourw lourw commented Feb 25, 2026

Current Behavior

Expected Behavior

The dependsOn of atomized tasks should match the base non-atomized task.

Related Issue(s)

Fixes Q-174

@netlify
Copy link

netlify bot commented Feb 25, 2026

Deploy Preview for nx-dev ready!

Name Link
🔨 Latest commit 4a51b61
🔍 Latest deploy log https://app.netlify.com/projects/nx-dev/deploys/699f434f8101630008e7a3ba
😎 Deploy Preview https://deploy-preview-34611--nx-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 25, 2026

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit 4a51b61
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/699f434f9347e30008aa932d
😎 Deploy Preview https://deploy-preview-34611--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lourw lourw force-pushed the lourw/add-depends-on-for-test-ci-tasks branch from bee8b05 to 2965711 Compare February 25, 2026 18:23
@nx-cloud
Copy link
Contributor

nx-cloud bot commented Feb 25, 2026

View your CI Pipeline Execution ↗ for commit 4a51b61

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 13m View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 3m 21s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 8s View ↗
nx-cloud record -- nx format:check ✅ Succeeded <1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-02-25 19:03:24 UTC

@lourw lourw enabled auto-merge (squash) February 25, 2026 18:37
Copy link
Contributor

@nx-cloud nx-cloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.

Nx Cloud has identified a possible root cause for your failed CI:

Our analysis shows this failure is environmental rather than code-related. The PR correctly adds dependsOn metadata to atomized test targets (validated by passing unit tests), but the e2e test encountered a Gradle daemon shutdown during the second atomized test run. The daemon management issue ("2 busy and 10 stopped Daemons could not be reused") and the sequential failure pattern (first test passed, second failed) indicate infrastructure resource problems rather than a code defect.

No code changes were suggested for this issue.

🔂 A CI rerun has been triggered by adding an empty commit to this branch.

Nx Cloud View detailed reasoning on Nx Cloud ↗

🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.


🎓 Learn more about Self-Healing CI on nx.dev

@lourw lourw self-assigned this Feb 25, 2026
@lourw lourw merged commit dc81b8b into master Feb 25, 2026
23 checks passed
@lourw lourw deleted the lourw/add-depends-on-for-test-ci-tasks branch February 25, 2026 19:03
FrozenPandaz pushed a commit that referenced this pull request Feb 26, 2026
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> The dependsOn of atomized tasks should match the base non-atomized task. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes Q-174 (cherry picked from commit dc81b8b)
FrozenPandaz pushed a commit that referenced this pull request Feb 26, 2026
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> The dependsOn of atomized tasks should match the base non-atomized task. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes Q-174 (cherry picked from commit dc81b8b)
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants