Skip to content

New interfaces#63

Merged
vouillon merged 13 commits intomasterfrom
new_interfaces
Apr 14, 2015
Merged

New interfaces#63
vouillon merged 13 commits intomasterfrom
new_interfaces

Conversation

@Drup
Copy link
Member

@Drup Drup commented Apr 2, 2015

A set of new interfaces, preliminary to the cohttp patch (but independent of cohttp).

I have not yet review in details, only shuffled until it was in an acceptable shape. Will probably keep shuffling. It builds and launches.

At least, I'm getting good at cherry-picking.

@Drup Drup mentioned this pull request Apr 2, 2015
@Drup Drup force-pushed the new_interfaces branch 2 times, most recently from edce084 to be8f076 Compare April 3, 2015 00:47
@Drup
Copy link
Member Author

Drup commented Apr 3, 2015

Except for commit 620edf8, of which I'm not convinced it's actually useful. The rest seems perfectly fine to me.

@Drup Drup force-pushed the new_interfaces branch 2 times, most recently from b032731 to f9dba07 Compare April 3, 2015 19:47
@Drup
Copy link
Member Author

Drup commented Apr 3, 2015

I moved the commit about Ocsigen_Is_a_directory in this branch. Everything seems fine to me, it's almost only refactoring. The patch for eliom is on the cohttp branch.

@vouillon @balat ?

@Drup Drup force-pushed the new_interfaces branch from f735436 to cef83a6 Compare April 4, 2015 23:20
@Drup Drup force-pushed the new_interfaces branch from cef83a6 to 9260404 Compare April 5, 2015 01:28
@Drup Drup force-pushed the new_interfaces branch from 99d9797 to 122129b Compare April 8, 2015 23:57
@Drup
Copy link
Member Author

Drup commented Apr 8, 2015

@vouillon I removed the cohttp mention in the documentation Makefile. Merge when you feel like it.

vouillon added a commit that referenced this pull request Apr 14, 2015
@vouillon vouillon merged commit 6668a7b into master Apr 14, 2015
@Drup Drup deleted the new_interfaces branch April 14, 2015 21:02
@Drup
Copy link
Member Author

Drup commented Apr 14, 2015

This patch breaks ocaml 3.12 because of the -bin-annot option, but cohttp is ocaml >= 4.01 only, so I guess we ca remove it anyway ?

@vasilisp vasilisp mentioned this pull request Jun 14, 2017
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants