Open
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
src/lib/bso/tasks/nexActivity.ts Outdated
| data | ||
| }); | ||
| | ||
| if (messages[1]) { |
Contributor
There was a problem hiding this comment.
Only the first two segments from splitMessage are sent. If splitMessage returns more than two parts, the extras are dropped. Consider iterating over all message parts.
Contributor
| So that is a serious thing. You can't send handleTripFinish multiple times for the same trip, because it will trigger all of the end-of-trip handlers multiple times. You'll need to figure out another way.... Iiirc Ignecarus had the same problem, why don't you look there to see how I fixed it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Will fix solo return trip showing loot and also in teams of 5+ people the trip will return.
Changes:
Will make a 2nd message when the character limit exceeds in the return trip.
Other checks: