Skip the blob failed model tests #1806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: hwangdeyu <dejack953@outlook.com>
hwangdeyu force-pushed the skip_failedblob_test branch from d60d521 to ec8b14c Compare 
fatcat-z reviewed Dec 20, 2021
| if os.environ.get('ENABLE_FULL_TRANSFORMER_TEST', '0') != '0': | ||
| enable_transformer_test = True | ||
| | ||
| def check_bloburl_access(): |
Collaborator
There was a problem hiding this comment.
I think we can add a common.py to save such common methods and avoid having duplicated ones in different tests files.
fatcat-z reviewed Dec 20, 2021
tests/keras2onnx_applications/nightly_build/test_transformers.py Outdated Show resolved Hide resolved
hwangdeyu force-pushed the skip_failedblob_test branch 3 times, most recently from 0039253 to ec7f29c Compare fatcat-z approved these changes Dec 20, 2021
hwangdeyu force-pushed the skip_failedblob_test branch from ec7f29c to 45247dd Compare Signed-off-by: hwangdeyu <dejack953@outlook.com>
hwangdeyu force-pushed the skip_failedblob_test branch 3 times, most recently from 92f8e90 to 0223bc9 Compare Signed-off-by: hwangdeyu <dejack953@outlook.com>
hwangdeyu force-pushed the skip_failedblob_test branch from 0223bc9 to eb3216f Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Signed-off-by: hwangdeyu dejack953@outlook.com
Co-authored-by: fatcat-z jiz@microsoft.com