Skip to content

Conversation

@southfreebird
Copy link
Contributor

This PR should solve a problem described in the issue: #1849

@fatcat-z
Copy link
Collaborator

fatcat-z commented Jul 22, 2022

Thanks for your contributions.
Please check the CI failures. Probably you should limit the min opset version for 2 test cases you added.

Signed-off-by: southfreebird <yvorott@gmail.com> Co-authored-by: southfreebird <yvorott@gmail.com> Co-authored-by: iolkhovsky <i.v.olkhovsky@gmail.com>
@southfreebird
Copy link
Contributor Author

It seems something wrong with python3.9 tests

@southfreebird
Copy link
Contributor Author

@fatcat-z
Could you help with tests please?
It seems something wrong with test_random_std_normal in python3.9 environment

@fatcat-z
Copy link
Collaborator

@fatcat-z Could you help with tests please? It seems something wrong with test_random_std_normal in python3.9 environment

Looking into it.

Copy link
Collaborator

@fatcat-z fatcat-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@fatcat-z fatcat-z merged commit 1c7d4ce into onnx:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants