Skip to content

Conversation

@y1yang0
Copy link
Contributor

@y1yang0 y1yang0 commented Nov 26, 2025

consolidate trampoline signature creation

simplify trampoline generation overall

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 89.54248% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.86%. Comparing base (659941e) to head (3a89a69).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tool/internal/instrument/trampoline.go 91.15% 8 Missing and 5 partials ⚠️
tool/ex/error.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## main #208 +/- ## ========================================== - Coverage 43.34% 42.86% -0.49%  ========================================== Files 37 37 Lines 2314 2319 +5 ========================================== - Hits 1003 994 -9  - Misses 1240 1250 +10  - Partials 71 75 +4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@y1yang0 y1yang0 marked this pull request as ready for review November 28, 2025 03:32
@y1yang0 y1yang0 requested a review from a team as a code owner November 28, 2025 03:32
return ok
}

func (c *HookContextImpl3378413897) GetParam(idx int) interface{} {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we unsupporting this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The c.params field stores pointers to pointers. Given this, it's better to fail completely rather than return partially correct and partially incorrect data.

For example, if c.params[1] is bad but *(c.params[2].(*string)) is good, the inconsistent result could lead to subtle and hard-to-debug issues. A complete failure is safer and more predictable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants