Open
Conversation
The particle patches lacked the `unitDimension` metadata attribute. This fixes it.
This was referenced Apr 17, 2024
s-sajid-ali approved these changes Apr 17, 2024
Member
s-sajid-ali left a comment
s-sajid-ali left a comment There was a problem hiding this comment.
Confirming that this file does not crash with the existing openpmd-ls (prior to fix in the openpmd-api repository).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The particle patches lacked the
unitDimensionmetadata attribute. This fixes it.X-ref: openPMD/openPMD-validator#75
Follow-up to #22