Skip to content

Conversation

@suchismith1993
Copy link

@suchismith1993 suchismith1993 commented Nov 20, 2025

Summary of the issues:

  1. There is no support for compiling AIX dynamic .a library and the tool was compiling .so files instead.
  2. There is no logic to support libclang.a.
  3. There is no support to load shared member of .a dynamic libraries of AIX.

JBS Issue: CODETOOLS-7904116


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (no review required)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jextract.git pull/297/head:pull/297
$ git checkout pull/297

Update a local copy of the PR:
$ git checkout pull/297
$ git pull https://git.openjdk.org/jextract.git pull/297/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 297

View PR using the GUI difftool:
$ git pr show -t 297

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jextract/pull/297.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 20, 2025

👋 Welcome back sroy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 20, 2025

@suchismith1993 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

Add support for AIX in build process 

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JornVernee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 20, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 20, 2025

Webrevs

Copy link
Member

@JornVernee JornVernee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Are you planning on using the MakeFile build? We are currently only using this for Oracle internal CI

build.gradle Outdated
Comment on lines 204 to 205
environment "CC", "/opt/IBM/xlC/13.1.3/bin/xlc"
environment "CXX", "/opt/IBM/xlC/13.1.3/bin/xlC"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover from testing I presume?

@suchismith1993
Copy link
Author

Question: Are you planning on using the MakeFile build? We are currently only using this for Oracle internal CI

Yes. There was no support for AIX , I had to add the path for libclang.a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review

2 participants