(helm/v1,ansible/v1) fix download URLs and order of binary checks #4407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
openshift-ci-robot added the kind/bug 
checks for all downloaded binaries Signed-off-by: Eric Stroczynski <estroczy@redhat.com>
estroz force-pushed the bugfix/download-operator-binaries branch from 28c36fb to 821c589 Compare 
Member Author
| /assign @theishshah |
Member Author
| /cherry-pick v1.3.x |
| @estroz: new pull request created: #4412 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Jan 23, 2021
…erator-framework#4407) Signed-off-by: Eric Stroczynski <estroczy@redhat.com>
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 4, 2021
…erator-framework#4407) Signed-off-by: Eric Stroczynski <estroczy@redhat.com> Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 4, 2021
…erator-framework#4407) Signed-off-by: Eric Stroczynski <estroczy@redhat.com> Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 5, 2021
…erator-framework#4407) Signed-off-by: Eric Stroczynski <estroczy@redhat.com> Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 5, 2021
…erator-framework#4407) Signed-off-by: Eric Stroczynski <estroczy@redhat.com> Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 5, 2021
…erator-framework#4407) Signed-off-by: Eric Stroczynski <estroczy@redhat.com> Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com> Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change: v1.3.0 changed the download URL for release artifacts so Makefiles must be updated (this needs to be backported). While fixing this I noticed that the downloaded binary is being re-downloaded if a global
helm-operatororansible-operatorbinary are present./kind bug
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs