Shell Script (Native Rust Binary) Installer - PATH should be only modified after successful download, add note like "Restart your shell or start new!" #44
Description
I have installed bum with Shell Script (Native Rust Binary) Installer:
curl -fsSL https://github.com/owenizedd/bum/raw/main/install.sh -o install-bum.sh sh install-bum.sh installation log:
######################################################################## 100.0% bun was installed successfully to ~/.bun/bin/bun Added "~/.bun/bin" to $PATH in "~/.zshrc" To get started, run: exec /bin/zsh bun --help -e Downloading bum (attempt 1/3)... ####################################################################################################################################################################################### 100.0% -e Download successful! x bum-v0.7.13-aarch64-apple-darwin/ x bum-v0.7.13-aarch64-apple-darwin/bum bum was installed successfully to /Users/user/.bum/bin/bum At first, I thought, the installer did not added binary to PATH, so I started to created this issues feature request
"Shell Script (Native Rust Binary) Installer should add binary to PATH"
But now this is minor logic change or log output change:
PATH should be only modified after successful download, and so installation output lines would look like
-e Download successful! ... Added "~/.bun/bin" to $PATH in "~/.zshrc" Restart your shell or start new! To get started, run: exec /bin/zsh bun --help Note added "Restart your shell or start new!" line.
This would also eliminated first-timer questions like mine and #33