CLN: cleanup hashtable.pyx #10111
Merged
CLN: cleanup hashtable.pyx #10111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jreback added the Compat 
Contributor
| looks ok. pls squash to a single commit when you are done. ping when green. |
remove unused variables and commented debug code do not store result of kh_put* when it is not used use khiter_t instead of int rename val & max_val to count & max_count for readability & consistency
gdementen force-pushed the hashtablecleanup branch from bffb646 to c2b58cb Compare Contributor Author
| @jreback ping! :) |
jreback added Clean and removed Compat Contributor
| thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
mostly remove unused stuff