fix _is_view for multi-block frames #11518
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nickeubank force-pushed the update_is_view branch from 5974ccb to 94703b2 Compare nickeubank force-pushed the update_is_view branch from 94703b2 to dd8de70 Compare 
Contributor
| read my comment in the code |
Contributor
| if u think his is necessary then it should go in your other pr |
Contributor Author
| @jreback OK -- need to be more conservative for copy-on-write. Will move into other PR |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
_is_view previously only testing whether first block was a view, when should return
_is_view = Trueif any block is a view.