Skip to content

Conversation

@nickeubank
Copy link
Contributor

Continuation of #11500

@nickeubank
Copy link
Contributor Author

@shoyer @jreback Ballpark timeline on refactor? Like, >1.5 years?

If so, I think I'll set this aside.Trying to modify the DataFrame constructor just opened a huge can of worms I think it'd take a long time to work through.

Till the refactor, any interest in making SettingWithCopyWarning into an exception?

@wesm
Copy link
Member

wesm commented Jan 20, 2016

I'd like to get it done in under a year; in combing through the codebase I've been making lists of things to do. It's a large effort but luckily we have a huge test suite to protect us and help keep the train on the rails. Will keep you posted

@nickeubank
Copy link
Contributor Author

@wesm Great. Then will def set aside. :)

@nickeubank nickeubank closed this Jan 20, 2016
@jreback
Copy link
Contributor

jreback commented Jan 20, 2016

@nickeubank thanks for all the effort / commentary tests. I think these will be useful in the refactor.

@nickeubank
Copy link
Contributor Author

@jreback thanks for the guidance! If nothing else, I now know a lot more about how references work in Python! :)

@TomAugspurger
Copy link
Contributor

@nickeubank If you want to apply that knowledge for some internet karma, this came up yesterday ;)

@nickeubank
Copy link
Contributor Author

@TomAugspurger on it, thanks Tom.

@pkch
Copy link

pkch commented Sep 4, 2016

Is there an open issue for this? I found a bunch of issues related to this, but didn't see any open ones.

@jreback
Copy link
Contributor

jreback commented Sep 4, 2016

there are refeneced issues

@shoyer
Copy link
Member

shoyer commented Sep 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment