Skip to content

REF: reorganize pandas/tests/test_series.py #12130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

REF: reorganize pandas/tests/test_series.py #12130

wants to merge 3 commits into from

Conversation

@wesm
Copy link
Member

@wesm wesm commented Jan 25, 2016

Similar to test_frame.py, but only 8K lines to deal with this time.
@wesm
Copy link
Member Author

wesm commented Jan 25, 2016

The sparse tests were relying on a small subset of unit tests in CheckNameIntegration (including several tests which didn't use non-sparse Series at all). I'll fix this up in the next day or two to get the build passing so this doesn't linger too long
@jreback jreback added the Clean label Jan 25, 2016
@jreback jreback added this to the 0.18.0 milestone Jan 25, 2016
@wesm
Copy link
Member Author

wesm commented Jan 26, 2016

@jreback Think I fixed the sparse tests, merge away after review when ready
@jreback jreback closed this in 91ee418 Jan 26, 2016
@jreback
Copy link
Contributor

jreback commented Jan 26, 2016

thanks!
jreback
jreback reviewed Jan 26, 2016
View reviewed changes
pandas/tests/series/common.py
Copy link
Contributor

@jreback jreback Jan 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not directly related, and maybe I am missing something, but these have to be strictly read only, enforced by the user. IOW. If in a single test class I modify one of these (say set an element of the Series), won't that persist? In the prior impl,, I believe these were recreated each time in setUp. So no possibility of that.
Copy link
Member Author

@wesm wesm Jan 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good point; to be on the safe side we should clear() the _cache variable (set by cache_readonly) in between unit tests. same with the DataFrame tests
@jreback jreback mentioned this pull request Jan 26, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Clean

2 participants

@wesm @jreback