Use correct random choice function in code snippet #12384
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
A hidden code snippet uses `tm.choice()` when it should use `np.random.choice()`
Contributor Author
| cc @ellisonbg |
Contributor
| @carroux thanks! |
Contributor
| so I think this was for numpy < 1.7 compat. pls remove this: https://github.com/pydata/pandas/blob/master/pandas/util/testing.py#L173 as well (its possible there are some other references as well), pls search the docs; in the code I think something will fail. thanks! |
Contributor
| oh, saw @TomAugspurger merged this, ok. then. |
Contributor
| Ha, sorry bout that. FYI pandas/tests/frame/test_query_eval.py 99: a = tm.choice(['red', 'green'], size=10) 100: b = tm.choice(['eggs', 'ham'], size=10) 152: a = tm.choice(['red', 'green'], size=10) 153: b = tm.choice(['eggs', 'ham'], size=10) 246: a = tm.choice(['red', 'green'], size=10) 978: a = Series(tm.choice(list('abcde'), 20)) pandas/tests/test_graphics_others.py 638: gender = tm.choice(['male', 'female'], size=n) 712: gender_int = tm.choice([0, 1], size=n) pandas/tests/test_graphics.py 63: gender = tm.choice(['Male', 'Female'], size=n) 64: classroom = tm.choice(['A', 'B', 'C'], size=n) 3864: gender = tm.choice(['male', 'female'], size=n) pandas/tools/tests/test_merge.py 239: df = DataFrame({'a': tm.choice(['m', 'f'], size=3), 241: df2 = DataFrame({'a': tm.choice(['m', 'f'], size=10), 248: df = DataFrame({'a': tm.choice(['m', 'f'], size=3), 251: df2 = DataFrame({'a': tm.choice(['m', 'f'], size=10), 257: df = DataFrame({'a': tm.choice(['m', 'f'], size=3), 259: df2 = DataFrame({'a': tm.choice(['m', 'f'], size=10), vb_suite/groupby.py 146:obj = tm.choice(list('ab'), size=n).astype(object)are the other occurrences, if we want to open a cleanup issue. |
This was referenced Feb 18, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
A hidden code snippet uses
tm.choice()when it should usenp.random.choice()