BUG: Fix #13213 json_normalize() and non-ascii characters in keys #13214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 2 commits May 18, 2016 14:46
pandas/tests/frame/test_json.py Outdated
| @@ -0,0 +1,26 @@ | |||
| # -*- coding: utf-8 -*- | |||
Contributor
There was a problem hiding this comment.
no, this can go (just the test), don't add a new file in pandas/io/tests/json/test_json_norm.py
Contributor Author
There was a problem hiding this comment.
Not sure I understand the second part, but I removed the encoding-line
jreback added Bug Unicode 
Contributor
| pls add a whatsnew note |
Contributor
| move the test to where I indicated |
Current coverage is 84.15%@@ master #13214 diff @@ ========================================== Files 138 138 Lines 50388 50394 +6 Methods 0 0 Messages 0 0 Branches 0 0 ========================================== + Hits 42386 42408 +22 + Misses 8002 7986 -16 Partials 0 0
|
Contributor
| thanks @fmarczin ! |
Contributor Author
| Thank you for taking care of this so fast! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff