TST: Fix MMapWrapper init test for Windows #13494
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jreback added Testing 
Contributor
| lgtm, ping when green. |
Current coverage is 84.33%@@ master #13494 diff @@ ========================================== Files 138 138 Lines 51106 51106 Methods 0 0 Messages 0 0 Branches 0 0 ========================================== Hits 43102 43102 Misses 8004 8004 Partials 0 0
|
gfyoung force-pushed the mmap-wrapper-init-test-fix branch from 1f55ac4 to db7c6b1 Compare 
Member Author
| @jreback : Travis is happy, so ready to merge if there are no concerns. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Turns out Windows errors differently when an invalid
filenois passed into themmapconstructor, so there's no need to skip the test (xref: 9670b31).