Fix missing not in format._put_lines #13552
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Current coverage is 84.31% (diff: 100%)@@ master #13552 diff @@ ========================================== Files 139 138 -1 Lines 50241 51157 +916 Methods 0 0 Messages 0 0 Branches 0 0 ========================================== + Hits 42851 43131 +280 - Misses 7390 8026 +636 Partials 0 0
|
| | ||
| def _put_lines(buf, lines): | ||
| if any(isinstance(x, compat.text_type) for x in lines): | ||
| if any(not isinstance(x, compat.text_type) for x in lines): |
Contributor
There was a problem hiding this comment.
why are you suggesting this change? This changes the display output of .info(). what exactly is the problem?
Author
| @jreback the following raises a TypeError import pandas as pd from io import StringIO buf = StringIO() pd.DataFrame().info(buf=buf) 2642 if any(isinstance(x, compat.text_type) for x in lines): 2643 lines = [compat.text_type(x) for x in lines] -> 2644 buf.write('\n'.join(lines)) 2645 2646 TypeError: unicode argument expected, got 'str'Which I believe this PR fixes (and is the proper intention of the code) |
Member
| @limx0 Can you add a test for the actual |
| skip = False | ||
| | ||
| def test_put_lines(self): | ||
| from io import StringIO |
Member
There was a problem hiding this comment.
StringIO is already imported from pandas.compat
Member
There was a problem hiding this comment.
further, can you add the pr number in a comment on the first line?
Author
| @jorisvandenbossche this is now working in the latest master. Closing this PR |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.