BLD: use tempita for hashtable #13815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Current coverage is 85.23% (diff: 100%)@@ master #13815 diff @@ ========================================== Files 140 140 Lines 50420 50420 Methods 0 0 Messages 0 0 Branches 0 0 ========================================== Hits 42975 42975 Misses 7445 7445 Partials 0 0
|
Member
There was a problem hiding this comment.
{{tab}} is pretty ugly! If tempita doesn't have a way to handle conditional indentation I would consider simply making separate blocks for each condition. That will be slightly more code but easier to understand.
Member Author
There was a problem hiding this comment.
Yes, using if-else is clearer in this case. fixed.
Contributor
| be sure to add to the linter as well. |
Member Author
| @jreback OK. linting is enabled for all |
Contributor
| thanks @sinhrks I know you wanted to add other types (e.g. int32), so can make another issue for that, but this is great. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff