solve list cannot add to tuple error in make_signature function #13878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

caikehe wants to merge 1 commit into pandas-dev:master from caikehe:master

caikehe commented Aug 2, 2016

closes #xxxx
tests added / passed
passes git diff upstream/master | flake8 --diff
whatsnew entry

solve list cannot add to tuple error in make_signature function

1ecdeb6

codecov-io commented Aug 2, 2016 •

edited

Loading

Current coverage is 85.23% (diff: 0.00%)

Merging #13878 into master will not change coverage

@@ master #13878 diff @@ ========================================== Files 140 140 Lines 50456 50456 Methods 0 0 Messages 0 0 Branches 0 0 ========================================== Hits 43007 43007 Misses 7449 7449 Partials 0 0

Powered by Codecov. Last update d4f95fd...1ecdeb6

Contributor

jreback commented Aug 2, 2016

what exactly does this break?

Author

caikehe commented Aug 3, 2016 •

edited

Loading

when I run an example like:

from pandas.util.decorators import make_signature
def f(a,b,c=2) :
return a_b_c

print(make_signature(f))

I got an error as:
defaults = ('',) * n_wo_defaults + spec.defaults
TypeError: can only concatenate tuple (not "list") to tuple

Contributor

jreback commented Aug 3, 2016

hmm, that does fail (only in py3). Well must have been a typo in the copy paste a while back. Can you add a test in pandas/tests/test_util.py. make_signature is actually used in pandas.core.groupby. Can you repro an error from something?

jreback added the Compat label

Contributor

jreback commented Sep 9, 2016

can you rebase / update?

caikehe closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment