MAINT: Use __module__ in _DeprecatedModule. #14181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Current coverage is 85.25% (diff: 86.66%)@@ master #14181 diff @@ ========================================== Files 140 140 Lines 50555 50544 -11 Methods 0 0 Messages 0 0 Branches 0 0 ========================================== - Hits 43095 43091 -4 + Misses 7460 7453 -7 Partials 0 0
|
gfyoung force-pushed the datetools-depr-cont branch from dc59364 to 8221c59 Compare 
Contributor
| somethings wrong. so now
nor does tab completion on the module can you add some tests for this |
Member Author
| @jreback : Did tab completion work before? |
Contributor
| yes |
Follow-up to pandas-devgh-14105. Uses the '__module__' method to correctly determine the location of the alternative module to use.
gfyoung force-pushed the datetools-depr-cont branch from 8221c59 to 2e581ab Compare Member Author
| @jreback : I couldn't get tab completion to issue a warning like that on |
Contributor
| wel it needs to be the same as master and have the warning and have the same behavior as 0.18.1 for function |
Member Author
| @jreback : Fair enough. I made some modifications. Can you take a look? |
Contributor
| tab complete / warnings loooking good |
Contributor
| lgtm. @jorisvandenbossche |
Member
| @gfyoung Thanks a lot! |
yarikoptic added a commit to neurodebian/pandas that referenced this pull request Oct 13, 2016
* commit 'v0.19.0rc1-25-ga7469cf': (471 commits) ENH: Add divmod to series and index. (pandas-dev#14208) Fix generator tests to run (pandas-dev#14245) BUG: GH13629 Binned groupby median function with empty bins (pandas-dev#14225) TST/TEMP: fix pyqt to 4.x for plotting tests (pandas-dev#14240) DOC: added example to Series.map showing use of na_action parameter (GH14231) DOC: split docstring into multiple lines in excel.py (pandas-dev#14073) MAINT: Use __module__ in _DeprecatedModule. (pandas-dev#14181) ENH: Allow true_values and false_values options in read_excel (pandas-dev#14002) DOC: fix incorrect example in unstack docstring (GH14206) (pandas-dev#14211) BUG: iloc fails with non lex-sorted MultiIndex pandas-dev#13797 BUG: add check for infinity in __call__ of EngFormatter In gbq.to_gbq allow the DataFrame column order to differ from schema BLD: require cython if tempita is needed DOC: add source links to api docs (pandas-dev#14200) BUG: compat with Stata ver 111 Fix: F999 dictionary key '2000q4' repeated with different values (pandas-dev#14198) BLD: Test for Python 3.5 with C locale BUG: DatetimeTZBlock can't assign values near dst boundary BUG: union_categorical with Series and cat idx BUG: fix str.contains for series containing only nan values ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Follow-up to #14105. Uses the
__module__method to correctly determine the location of the alternativemodule to use.