Skip to content

BUG: Fixed DataFrame.describe percentiles are ndarray w/ no median #14914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

BUG: Fixed DataFrame.describe percentiles are ndarray w/ no median #14914

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a06794d
BUG: Fixed bug in DataFrame.describe when percentiles are passed as a…
pbreach Dec 19, 2016
d192ac7
Fixed whitespace issue
pbreach Dec 19, 2016
f954392
Moved conversion to if percentiles is not None
pbreach Dec 19, 2016
72fe0cb
Added what's new entry
pbreach Dec 19, 2016
b5d09a6
Added test for median insertion with ndarray
pbreach Dec 19, 2016
5c8199b
Minor test fix
pbreach Dec 19, 2016
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added test for median insertion with ndarray
  • Loading branch information
@pbreach
pbreach committed Dec 19, 2016
commit b5d09a6a384ffa348b4e15d92d3b9a87d873853c
9 changes: 9 additions & 0 deletions pandas/tests/test_generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -996,6 +996,15 @@ def test_describe_percentiles_insert_median(self):
self.assertTrue('0%' in d1.index)
self.assertTrue('100%' in d2.index)

def test_describe_percentiles_insert_median_ndarray(self):
df = tm.makeDataFrame()
Copy link
Contributor

@jreback jreback Dec 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the issue number here as a comment
try:
Copy link
Contributor

@jreback jreback Dec 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need the try/except at all; nose will simply fail the test if this raises.

rename d1 -> result, d2 -> expected
d1 = df.describe(percentiles=np.array([.25, .75]))
except AttributeError:
self.fail
d2 = df.describe(percentiles=[.25, .75])
assert_frame_equal(d1, d2)

def test_describe_percentiles_unique(self):
# GH13104
df = tm.makeDataFrame()
Expand Down