MAINT: Remove assertNotIn from testing #16096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Rewrite _AssertRaisesContextManager with more documentation and remove vestigial assertRaises. Follow-up to pandas-devgh-16089.
Codecov Report
@@ Coverage Diff @@ ## master #16096 +/- ## ========================================== + Coverage 90.83% 90.84% +<.01% ========================================== Files 159 159 Lines 50783 50778 -5 ========================================== Hits 46131 46131 + Misses 4652 4647 -5
Continue to review full report at Codecov.
|
Contributor
| thanks! |
pcluo pushed a commit to pcluo/pandas that referenced this pull request May 22, 2017
* MAINT: Refactor _AssertRaisesContextManager Rewrite _AssertRaisesContextManager with more documentation and remove vestigial assertRaises. Follow-up to pandas-devgh-16089. * MAINT: Remove assertNotIn from testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Title is self-explanatory.
Partially addresses #15990.