Skip to content

BUG: Don't segfault to_numeric when input is empty #16305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2017
Merged

BUG: Don't segfault to_numeric when input is empty #16305

merged 1 commit into from
May 9, 2017

Conversation

@gfyoung
Copy link
Member

@gfyoung gfyoung commented May 9, 2017

Title is self-explanatory.

Closes #16302.
@jorisvandenbossche jorisvandenbossche added Numeric Operations Arithmetic, Comparison, and Logical operations Regression Functionality that used to work in a prior pandas version labels May 9, 2017
@jorisvandenbossche jorisvandenbossche added this to the 0.20.2 milestone May 9, 2017
@jreback
Copy link
Contributor

jreback commented May 9, 2017

lgtm. ping on green.
@codecov
Copy link

codecov bot commented May 9, 2017 •
edited
Loading

Codecov Report

Merging #16305 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #16305 +/- ## ========================================== - Coverage 90.39% 90.37% -0.03%  ========================================== Files 161 161 Lines 50863 50863 ========================================== - Hits 45977 45966 -11  - Misses 4886 4897 +11
Flag Coverage Δ
#multiple 88.15% <ø> (-0.01%) ⬇️
#single 40.33% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/util/testing.py 80.21% <0%> (-0.2%) ⬇️
pandas/core/frame.py 97.59% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce4eef3...9d79605. Read the comment docs.
@gfyoung
Copy link
Member Author

gfyoung commented May 9, 2017

@jreback : Everything is green and ready to go.
@jorisvandenbossche jorisvandenbossche merged commit 81aa70c into pandas-dev:master May 9, 2017
@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented May 9, 2017

Thanks!
@gfyoung gfyoung deleted the to-numeric-segfault branch May 9, 2017 19:58
pawroman pushed a commit to pawroman/pandas that referenced this pull request May 9, 2017
@gfyoung @pawroman
BUG: Don't segfault to_numeric when input is empty (pandas-dev#16305)
31c82c0 
Closes pandas-devgh-16302.
pcluo pushed a commit to pcluo/pandas that referenced this pull request May 22, 2017
@gfyoung @pcluo
BUG: Don't segfault to_numeric when input is empty (pandas-dev#16305)
2d9b36a 
Closes pandas-devgh-16302.
TomAugspurger pushed a commit to TomAugspurger/pandas that referenced this pull request May 29, 2017
@gfyoung @TomAugspurger
BUG: Don't segfault to_numeric when input is empty (pandas-dev#16305)
9e77690 
Closes pandas-devgh-16302. (cherry picked from commit 81aa70c)
TomAugspurger pushed a commit that referenced this pull request May 30, 2017
@gfyoung @TomAugspurger
BUG: Don't segfault to_numeric when input is empty (#16305)
84b024f 
Closes gh-16302. (cherry picked from commit 81aa70c)
@TomAugspurger TomAugspurger mentioned this pull request Jun 5, 2017
Closed
stangirala pushed a commit to stangirala/pandas that referenced this pull request Jun 11, 2017
@gfyoung @stangirala
BUG: Don't segfault to_numeric when input is empty (pandas-dev#16305)
67c4ada 
Closes pandas-devgh-16302.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Numeric Operations Arithmetic, Comparison, and Logical operations Regression Functionality that used to work in a prior pandas version

4 participants

@gfyoung @jreback @jorisvandenbossche @TomAugspurger