BUG: Categorical constructor scalar categories #16340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| lgtm. |
Codecov Report
@@ Coverage Diff @@ ## master #16340 +/- ## ========================================== - Coverage 90.38% 90.36% -0.03% ========================================== Files 161 161 Lines 50916 50918 +2 ========================================== - Hits 46020 46011 -9 - Misses 4896 4907 +11
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@ ## master #16340 +/- ## ========================================== - Coverage 90.4% 90.36% -0.05% ========================================== Files 161 161 Lines 50933 50935 +2 ========================================== - Hits 46048 46027 -21 - Misses 4885 4908 +23
Continue to review full report at Codecov.
|
jorisvandenbossche approved these changes May 12, 2017
doc/source/whatsnew/v0.21.0.txt Outdated
| Categorical | ||
| ^^^^^^^^^^^ | ||
| | ||
| - The Categorical constructor no longer accepts a scalar for the ``categories`` keyword (:issue:`16022`) |
Member
There was a problem hiding this comment.
put it in api changes section ?
Categorical constructor no longer accepts scalars for categories. Closes pandas-dev#16022
TomAugspurger force-pushed the categorical-scalar branch from 91bb0fd to d898b8b Compare pawroman added a commit to pawroman/pandas that referenced this pull request May 18, 2017
* upstream/master: (48 commits) BUG: Categorical comparison with unordered (pandas-dev#16339) ENH: Adding 'protocol' parameter to 'to_pickle'. PERF: improve MultiIndex get_loc performance (pandas-dev#16346) TST: remove pandas-datareader xfail as 0.4.0 works (pandas-dev#16374) TST: followup to pandas-dev#16364, catch errstate warnings (pandas-dev#16373) DOC: new oauth token TST: Add test for clip-na (pandas-dev#16369) ENH: Draft metadata specification doc for Apache Parquet (pandas-dev#16315) MAINT: Add .iml to .gitignore (pandas-dev#16368) BUG/API: Categorical constructor scalar categories (pandas-dev#16340) ENH: Provide dict object for to_dict() pandas-dev#16122 (pandas-dev#16220) PERF: improved clip performance (pandas-dev#16364) DOC: try new token for docs DOC: try with new secure token DOC: add developer section to the docs DEPS: Drop Python 3.4 support (pandas-dev#16303) DOC: remove credential helper DOC: force fetch on build docs DOC: redo dev docs access token DOC: add dataframe construction in merge_asof example (pandas-dev#16348) ...
pcluo pushed a commit to pcluo/pandas that referenced this pull request May 22, 2017
* BUG: Categorical constructor scalar categories Categorical constructor no longer accepts scalars for categories. Closes pandas-dev#16022
stangirala pushed a commit to stangirala/pandas that referenced this pull request Jun 11, 2017
* BUG: Categorical constructor scalar categories Categorical constructor no longer accepts scalars for categories. Closes pandas-dev#16022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Categorical constructor no longer accepts scalars for categories.
Closes #16022