BUG Fix for Issue #12565 - font size on secondary_y #16952
Conversation
There may be other plotting methods that need testing.
| Hello @Morgan243! Thanks for updating the PR.
Comment last updated on July 15, 2017 at 20:25 Hours UTC |
| | ||
| @pytest.mark.parametrize('method', ['line', 'barh', 'bar']) | ||
| def test_secondary_axis_font_size(self, method): | ||
| df = (pd.DataFrame(np.random.randn(15, 2), |
There was a problem hiding this comment.
Can add comment with the github issue number here like # GH: 12565
Codecov Report
@@ Coverage Diff @@ ## master #16952 +/- ## ========================================== - Coverage 90.98% 90.97% -0.02% ========================================== Files 161 161 Lines 49288 49292 +4 ========================================== - Hits 44846 44844 -2 - Misses 4442 4448 +6
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@ ## master #16952 +/- ## ========================================== - Coverage 90.98% 90.97% -0.02% ========================================== Files 161 161 Lines 49288 49292 +4 ========================================== - Hits 44846 44844 -2 - Misses 4442 4448 +6
Continue to review full report at Codecov.
|
doc/source/whatsnew/v0.21.0.txt Outdated
| Plotting | ||
| ^^^^^^^^ | ||
| | ||
| - Bug in plotting methods using ``secondary_y`` and ``fontsize`` not setting secondary axes font size (:issue:`12565`) |
There was a problem hiding this comment.
I agree, I think 'axis' is right
| @Morgan243 : Ping when tests pass, and we will merge this! |
| @gfyoung tests passed! |
| Thanks @Morgan243 ! |
5 participants
There may be other plotting methods that need testing.
git diff upstream/master -u -- "*.py" | flake8 --diff