Skip to content

Conversation

@uiur
Copy link

@uiur uiur commented Aug 1, 2017

This is a failing test for #17135 to reproduce the behavior.

@codecov
Copy link

codecov bot commented Aug 1, 2017

Codecov Report

Merging #17136 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #17136 +/- ## ========================================== - Coverage 91.03% 90.98% -0.05%  ========================================== Files 161 161 Lines 49405 49405 ========================================== - Hits 44974 44950 -24  - Misses 4431 4455 +24
Flag Coverage Δ
#multiple 88.77% <ø> (-0.02%) ⬇️
#single 40.2% <ø> (-0.14%) ⬇️
Impacted Files Coverage Δ
pandas/io/feather_format.py 20% <0%> (-65.72%) ⬇️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.56% <0%> (-0.2%) ⬇️
pandas/core/series.py 94.85% <0%> (-0.1%) ⬇️
pandas/core/generic.py 91.96% <0%> (-0.06%) ⬇️
pandas/plotting/_converter.py 65.05% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2b0bdc...c8dcf19. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 1, 2017

Codecov Report

Merging #17136 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #17136 +/- ## ========================================== - Coverage 91.03% 90.98% -0.05%  ========================================== Files 161 161 Lines 49405 49405 ========================================== - Hits 44974 44950 -24  - Misses 4431 4455 +24
Flag Coverage Δ
#multiple 88.77% <ø> (-0.02%) ⬇️
#single 40.2% <ø> (-0.14%) ⬇️
Impacted Files Coverage Δ
pandas/io/feather_format.py 20% <0%> (-65.72%) ⬇️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.56% <0%> (-0.2%) ⬇️
pandas/core/series.py 94.85% <0%> (-0.1%) ⬇️
pandas/core/generic.py 91.96% <0%> (-0.06%) ⬇️
pandas/plotting/_converter.py 65.05% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2b0bdc...c8dcf19. Read the comment docs.

@gfyoung
Copy link
Member

gfyoung commented Aug 1, 2017

@uiureo : For us to accept this patch, we would need you to patch existing behavior, not just fix the test to reproduce a failure.

@gfyoung gfyoung added IO Data IO issues that don't fit into a more specific label Regression Functionality that used to work in a prior pandas version labels Aug 1, 2017
@jreback
Copy link
Contributor

jreback commented Sep 23, 2017

@uiureo can you make this into an xfailing test.

note that moto is now used to mock these types of things, so it should be against that as well.

@jreback
Copy link
Contributor

jreback commented Oct 29, 2017

can you rebase and update according to comments.

@jreback
Copy link
Contributor

jreback commented Nov 25, 2017

closing as stale

@jreback jreback closed this Nov 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IO Data IO issues that don't fit into a more specific label Regression Functionality that used to work in a prior pandas version

3 participants