Cut/paste (most) remaining tz funcs to tslibs/timezones #17526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jreback requested changes Sep 14, 2017
Contributor
jreback left a comment
jreback left a comment There was a problem hiding this comment.
looks fine. need to get passing of course. also run some asv for timezones to confirm no changes.
pandas/_libs/period.pyx Outdated
| | ||
| | ||
| cpdef int64_t period_ordinal_to_dt64(int64_t ordinal, int freq) nogil: | ||
| cpdef period_ordinal_to_dt64(int64_t ordinal, int freq) nogil: |
Member Author
There was a problem hiding this comment.
That's a mistake-- and apparently the cause of the build errors. Just pushed a fix.
Member Author
|
Contributor
| can you run benches for |
Member Author
|
Contributor
| those are wildly inconsitent. do are using affinity? |
Member Author
| Did the previous asv run on the laptop. New one on the desktop: |
Contributor
| ok that looks good. something failing.ping when green. |
Codecov Report
@@ Coverage Diff @@ ## master #17526 +/- ## ========================================== + Coverage 91.18% 91.2% +0.02% ========================================== Files 163 163 Lines 49545 49606 +61 ========================================== + Hits 45179 45245 +66 + Misses 4366 4361 -5
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@ ## master #17526 +/- ## ========================================== + Coverage 91.18% 91.2% +0.02% ========================================== Files 163 163 Lines 49545 49606 +61 ========================================== + Hits 45179 45245 +66 + Misses 4366 4361 -5
Continue to review full report at Codecov.
|
Member Author
| ping. |
jreback approved these changes Sep 15, 2017
Contributor
| thanks; would take a followup for _ renaming as well. |
4 tasks
alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We're very nearly done with
tslibs.timezones. I had hoped to bring over the remaining functions in smaller chunks, but this turns out to be the smallest independent subset that contains_get_dst_infoandmaybe_get_tz.Getting
_get_dst_infoandmaybe_get_tzseparated is a milestone because it allows us to movetseries.frequencies.Resolutionand related functions into cython without having a dependency ontslib. This in turn gets the dependency onkhashout oftslib. A few more nice things become feasible.This is almost pure cut/paste. The only change I made was replacing
isinstance(tz, string_types)withis_string_object(tz). If requested, I'll do a follow-up to de-privatize the names.timezonesis within spitting distance of being valid python. Getting it over that hump would allow linting and coverage that is tough as it is.Note that if/when #17363 is merged, a bunch of residual imports in
tslibcan be cleaned up.git diff upstream/master -u -- "*.py" | flake8 --diff