BUG: Fix df.loc slice support #18703
Conversation
| xp = mi_labels.ix['j'].ix[:, 'j'].ix[0, 0] | ||
| assert rs == xp | ||
| | ||
| # GH8856 |
| return mask | ||
| | ||
| if not isinstance(key, tuple): | ||
| if isinstance(key, slice): |
There was a problem hiding this comment.
can u add some comments here
| tm.assert_frame_equal(rs, xp) | ||
| | ||
| # GH8856 | ||
| s = pd.Series(np.arange(10), |
There was a problem hiding this comment.
is this a duplicate of the other test?
| | ||
| # GH8856 | ||
| s = pd.Series(np.arange(10), | ||
| pd.MultiIndex.from_product(([0, 1], list('abcde')))) |
There was a problem hiding this comment.
can u add several cases using slices
also if other testing of slice u can pull to this section
| @jreback Oops, sorry! I overlooked another test. Input:s = pd.Series(np.arange(8), pd.MultiIndex.from_product(([0, 1, 2, 3], list('ab')))) s.loc[::2] = 200 sOutput:But, this returns the crazy result. Input:index = pd.MultiIndex(levels=[['foo', 'bar', 'baz', 'qux'], ['one', 'two','three']], labels=[[0, 0, 0, 1, 1, 2, 2, 3, 3, 3], [0, 1, 2, 0, 1, 1, 2, 0, 1, 2]], names=['first', 'second']) frame = pd.DataFrame(np.random.randn(10, 3), index=index, columns=pd.Index(['A', 'B', 'C'], name='exp')) frame.loc['foo':'bar':4]Output: |
jreback added Indexing 
| @toobaz if you'd have a look |
| I think slicing by string is not good since |
| @Licht-T : I'm confused. Unless I'm missing anything, your changes to code are limited to
... ? |
| closing as stale. ping if you want to update. |
3 participants
git diff upstream/master -u -- "*.py" | flake8 --diff