Fixed pct_change with 'fill_method' returning NaN instead of 0 #19875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jreback reviewed Feb 24, 2018
pandas/tests/generic/test_generic.py Outdated
| def test_pct_change(self, periods, fill_method, limit, exp): | ||
| obj = self._construct(0) | ||
| if type(obj) is Panel: | ||
| pytest.skip("Not testing deprecated Panel") |
Contributor
There was a problem hiding this comment.
just add this method to the Panel section and it will skip automatically
WillAyd force-pushed the pct-change-fill branch from 9320540 to 69624f3 Compare WillAyd changed the title 
Codecov Report
@@ Coverage Diff @@ ## master #19875 +/- ## ========================================== - Coverage 91.68% 91.64% -0.04% ========================================== Files 150 150 Lines 48915 48946 +31 ========================================== + Hits 44847 44856 +9 - Misses 4068 4090 +22
Continue to review full report at Codecov.
|
jreback requested changes Feb 24, 2018
pandas/tests/generic/test_generic.py Outdated
| func = getattr(obj, 'pct_change') | ||
| res = func(periods=periods, fill_method=fill_method, limit=limit) | ||
| | ||
| # Convert output into Series, regardless of input type |
Contributor
There was a problem hiding this comment.
if you rename obj above, you can simply determine the output down here, and make this a bit less convoluted, e.g.
if type(obj) is DataFrame: # compare dataframe else: # compare series 
jreback added Bug Missing-data 
WillAyd force-pushed the pct-change-fill branch from 2bd760a to d687383 Compare 
Member Author
| Failed Travis tests don't appear related to the change |
Contributor
| thanks @WillAyd |
harisbal pushed a commit to harisbal/pandas that referenced this pull request Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff