Skip to content

Conversation

@alexandrebarbaruiva
Copy link

Checklist for the pandas documentation sprint (ignore this if you are doing
an unrelated PR):

  • PR title is "DOC: update the docstring"
  • The validation script passes: scripts/validate_docstrings.py <your-function-or-method>
  • The PEP8 style check passes: git diff upstream/master -u -- "*.py" | flake8 --diff
  • The html version looks good: python doc/make.py --single <your-function-or-method>
  • It has been proofread on language by another sprint participant

Please include the output of the validation script below between the "```" ticks:

Docstring for "pandas.core.dtypes.inference.is_list_like" correct. :) 
"""
Check if the object is a number.
Booleans are valid because they are int subclass.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did this come from a separate PR? Can you revert he changes here so they don't conflict with that PR?

>>> pd.api.types.is_number(1)
True
>>> is_number("foo")
>>> pd.api.types.is_number(7.15)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this looks like it got mixed with separate PR, can you revert here

@jreback jreback added the Dtype Conversions Unexpected or buggy dtype conversions label Mar 10, 2018
@codecov
Copy link

codecov bot commented Mar 11, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@8c77238). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #20207 +/- ## ========================================= Coverage ? 91.7% ========================================= Files ? 150 Lines ? 49152 Branches ? 0 ========================================= Hits ? 45074 Misses ? 4078 Partials ? 0
Flag Coverage Δ
#multiple 90.08% <ø> (?)
#single 41.84% <ø> (?)
Impacted Files Coverage Δ
pandas/core/dtypes/inference.py 98.41% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c77238...dfb5f09. Read the comment docs.

@alexandrebarbaruiva alexandrebarbaruiva deleted the is_list_like branch March 11, 2018 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs Dtype Conversions Unexpected or buggy dtype conversions

4 participants