BUG: Avoid splitting string with list() (#20592) #20615
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| This needs tests |
Codecov Report
@@ Coverage Diff @@ ## master #20615 +/- ## ========================================== + Coverage 91.82% 91.84% +0.02% ========================================== Files 153 153 Lines 49256 49258 +2 ========================================== + Hits 45227 45243 +16 + Misses 4029 4015 -14
Continue to review full report at Codecov.
|
Contributor
TomAugspurger added the Indexing 
jreback requested changes Apr 5, 2018
| except Exception: | ||
| pass | ||
| | ||
| if not isinstance(key, (list, Series, np.ndarray, Series)): |
Contributor
There was a problem hiding this comment.
looks like extra Series listed here.
| | ||
| if not isinstance(key, (list, Series, np.ndarray, Series)): | ||
| try: | ||
| key = list(key) |
Contributor
There was a problem hiding this comment.
let's break this if up to specificy target a string e.g.
if isinstance(key, compat.string_types): ...... elif not isinstance(key, (list, Series, np.ndarray)): .... 
Contributor
| closing as stale, though would certainly take a PR here |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Solves #20592 and I doubt that there are any cases when a key string should be split by
list()