DOC: add concatenation-section to text.rst #20790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #20790 +/- ## ========================================== - Coverage 91.85% 91.84% -0.01% ========================================== Files 153 153 Lines 49308 49308 ========================================== - Hits 45290 45288 -2 - Misses 4018 4020 +2
Continue to review full report at Codecov.
|
jreback requested changes Apr 23, 2018
Contributor
jreback left a comment
jreback left a comment There was a problem hiding this comment.
looks good. very minor comment
doc/source/text.rst Outdated
| u = pd.Series(['b', 'd', 'a', 'c'], index=[1, 3, 0, 2]) | ||
| # without alignment | ||
| s.str.cat(u) | ||
| # manual alignment |
Contributor
There was a problem hiding this comment.
can you say this is in a more user friendly way (don't like the word manual)
Contributor Author
There was a problem hiding this comment.
Here's another try. As an aside, the lack of alignment isn't user-friendly (which is exactly the point of #20347)
Contributor
Contributor Author
| Build failure is not due to my commits (which do not touch the code base, just docs) |
Contributor
| thanks |
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As requested by @jreback in #20347.