remove daytime attr, move getstate and setstate to base class #21533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| lgtm. ping on green. |
Codecov Report
@@ Coverage Diff @@ ## master #21533 +/- ## ========================================== - Coverage 91.92% 91.92% -0.01% ========================================== Files 153 153 Lines 49594 49570 -24 ========================================== - Hits 45590 45566 -24 Misses 4004 4004
Continue to review full report at Codecov.
|
Contributor
| thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
If/when #18224 is revived to make
_BaseOffsetacdef class, we'll need to move__getstate__and__setstate__into the base class (and then make some changes). This moves the two methods pre-emptively so that we'll have a smaller diff for the next steps.Also removes an attr
self.daytimethat is not used anywhere else.