-
- Notifications
You must be signed in to change notification settings - Fork 19.4k
CI: Linting with azure instead of travis #22854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
120 commits Select commit Hold shift + click to select a range
46620f2 Moving one-line linting and checks from lint.sh to azure steps
datapythonista dc8c528 Moving everything from lint.sh to azure (so far repeating the command…
datapythonista adeb0ca Fixing continueOnError settings
datapythonista dcfb203 Reverting the exit status of the grep commands, we want them to fail …
datapythonista b765df8 Testing the continueOnError, doesn't seem to be working at job level,…
datapythonista 3c77fc9 Escaping exclamation marks to reverse the exist status of grep, azure…
datapythonista 3d8af7d Adding the continueOnError to every step, and trying if bash instead …
datapythonista ed1064d Fixes to missing continueOnError, and to the grep command exit status
datapythonista 8cb7b0f Testing couple of ways to invert the exit status of grep
datapythonista dee5a08 Fixing azure config syntax error
datapythonista 54f9e98 Fixing the checks (they should be ok now), and adding an intentional …
datapythonista 20cb360 Removing intentional pep8 issue, and fixing last known problems
datapythonista 50d2757 fixing style of azure settings
datapythonista 19a213c Replacing continueOnError (that converts errors in warnings) to condi…
datapythonista 0cf5da9 Fixing multiline in yaml, and removing job level continueOnError
datapythonista 4d10702 Changing the format of flake8 output to azure (so it creates links, a…
datapythonista a356f03 Removing unnecessary quotes in flake8 format config
datapythonista 50cb867 flake8 format breaks pip (ConfigParser) when present in setup.cfg, mo…
datapythonista 091193c Adding azure formatting to all failing flake8
datapythonista 4a2ddba Merging from master
datapythonista e7c276a Fixing azure job name
datapythonista 8f73c08 Making the format look good for flake8 and patterns, and adding file …
datapythonista 87b5048 Trying if environment variables can be defined in the script setting
datapythonista dc2e3a6 Merging from master
datapythonista 5ab03ab Removing file with errors to be displayed, and comment in the setup.cfg
datapythonista ca9e12a Changing cython cast grep to invgrep
datapythonista c591a17 Merging from master
datapythonista c671da5 Building source of the checks build and moving the documentation buil…
datapythonista a6eed3e Adding dependencies file for the checks and doc build
datapythonista 3b853f9 Renaming conda yaml env variable
datapythonista 850202d Fixing env variables to set up conda
datapythonista a896532 Debugging why azure is not installing desired dependencies
datapythonista bed55be Fixing once more env variables
datapythonista e555ce0 Fixing indentation in dependencies file
datapythonista 101f7f3 Adding missing env variables and dependencies
datapythonista fce22e6 Fixing unset env variables for the doc build
datapythonista 167f6dc Fixing directory for the doc build script
datapythonista d44f189 WIP: Testing a simpler way to build and upload the documentation
datapythonista 906da22 Printing installed dependencies in checks job (temporary, to debug py…
datapythonista 9fb3999 Printing installed dependencies in azure, for debugging
datapythonista c72c0e5 Fixing bug when uploading the docs to github pages
datapythonista de1f52f Adding an extra error to the validation of docstrings, as it's been f…
datapythonista e4aa371 Adding new docstring error code to the validation, and tests with the…
datapythonista f33b6e6 Merging from master
datapythonista 63cfd5b Generating the script of the deps check in azure format
datapythonista eb558df Publishing docs with azure artifacts instead of github pages, and add…
datapythonista 371f06e Removing unnecessary checks on travis on whether the doc is being bui…
datapythonista ca6e910 Merge remote-tracking branch 'upstream/master' into azure_lint
datapythonista d262a04 Debugging why pyqt is not being installed
datapythonista fc4574c Merge remote-tracking branch 'upstream/master' into azure_lint
datapythonista 168ec55 Adding section names check to validate docstrings, now that all wrong…
datapythonista 2f1b270 Fixing conda install pyqt for debugging
datapythonista 798698d Merging from master
datapythonista a3f601c Using github pages to publish the documentation
datapythonista 5ea21c6 Testing if linux variables can be defined once for the whole job
datapythonista 46d281c Using env for the environment variables, and implemented azure storag…
datapythonista faf49e9 Fixing typo
datapythonista fa4f16c Setting environment variables at the beginning of the job, and adding…
datapythonista c05f6b7 Fixing /home/mgarcia/miniconda3/envs/pandas-dev/bin:/home/mgarcia/min…
datapythonista 9162aeb Fixed typo in PATH
datapythonista 5640907 Formatting flake8-rst output for azure
datapythonista 0286099 Merge remote-tracking branch 'upstream/master' into azure_lint
datapythonista 629a209 Updating azure connection string
datapythonista 588d153 Checking if environment.yml can be used for the docs and checks build…
datapythonista bc9c3b3 Remove unused stuff from azure config
datapythonista 324b1e2 Doing checks as soon as possible (before conda, before build)
datapythonista 5bf1709 Fixing build errors (typo in dependencies, missing cpplint, code chec…
datapythonista 7cf2d68 Addapting generate_pip_deps_from_conda.py to support pip dependencies…
datapythonista 2f8441e Setting DISPLAY env to see if that fixes the to_clipboard problem
datapythonista 30ba23e Consistent way to source the conda environment
datapythonista 85172b3 Fixing typo in environment name, and removing pyqt debug info
datapythonista 450f84a Adding checkpoints to see where the docstests change the exit status
datapythonista 7b4b1ea Restoring required html5lib dependency
datapythonista 5d69e8b Removing travis doc job
datapythonista 3ce1aa0 Removing linting comments, and token for the docs from travis
datapythonista ee01df4 removing checkpoints and increasing verbosity of failing doctests
datapythonista e353e8a Restoring bf4 in travis deps, as it's required, and fixing the to_cli…
datapythonista 92a3921 Moving scripts unit tests to azure
datapythonista 9e34037 Adding conda environment to run scripts tests, and changing verbosity…
datapythonista 5a82f59 Using connection string secret variable instead of composing it in th…
datapythonista 6cbb31b Adding benchmark run to the CI
datapythonista 2617696 Merge remote-tracking branch 'upstream/master' into azure_lint
datapythonista 75ad473 Adding git remote for the benchmarks, and removing connection string …
datapythonista 7af04e1 Providing azure storage info as arguments instead of env, and fetchin…
datapythonista cc4331c Trying to fix benchmarks and azure storage issues
datapythonista c5df401 Testing if azure storage key has a missing =, and setting up machine …
datapythonista 4eac8bb More changes to the doc upload and the benchmarks, to try to make the…
datapythonista 00032d1 More fixes to doc upload and benchmarks
datapythonista e9ab754 Adding debug info for the docs upload and the benchmarks
datapythonista e47b4e1 Fixing bug in benchmarks set up, and fixing docstring errors, so vali…
datapythonista d0d4ae1 Merge remote-tracking branch 'upstream/master' into azure_lint
datapythonista a225d44 Clean up of debug info
datapythonista d6d5c66 Uploading docs to GitHub pages in the same way as travis
datapythonista f7a6048 Adding variable group to the job config, to see if that makes them ac…
datapythonista 9aa18d0 WIP: Restoring travis documentation build
datapythonista 283233d Restoing documentation build in travis
datapythonista 991304d Removing variable group, as variables are not in a group anymore, and…
datapythonista 3a71185 Merge remote-tracking branch 'upstream/master' into azure_lint
datapythonista 19c396f Adding missing conda environment activation
datapythonista a69e667 Fixing docstring errors
datapythonista 59d55d8 Removing documentation build from azure
datapythonista df50c58 Merge remote-tracking branch 'upstream/master' into azure_lint
datapythonista 455e77c Adding debug info to diagnose /home/mgarcia/miniconda3/bin:/home/mgar…
datapythonista 7f48ac2 adding more debug information
datapythonista 078a987 Revert "Removing documentation build from azure"
datapythonista d7883a1 Clean up of debug commands
datapythonista c2be491 Removing doc build in azure (restored because of the path problem)
datapythonista 910825a Building docs in azure, and uploading them to azure storage if it's a…
datapythonista 35c7d99 Merge remote-tracking branch 'upstream/master' into azure_lint
datapythonista d321a42 Merging from master
datapythonista 4328b04 Fixing pending docstrings
datapythonista 4c57f48 Updating dependencies with the version that fixes the speed problems
datapythonista 497f032 Updating pip requirements
datapythonista c88911a Always uploading docs (removed if to test if uploading the docs work …
datapythonista 75b89eb Adding parallelization to build and docs
datapythonista 011950e Removing documentation build in azure, and reverting using more than …
datapythonista 01942b9 Made an invgrep a newly added pattern validation
datapythonista 0a14165 Merging from master
datapythonista 705eb9d Regenerating pip dependencies
datapythonista 498cebb Merging from master
datapythonista File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Setting environment variables at the beginning of the job, and adding…
… debug information on directories
- Loading branch information
commit fa4f16cb1fa937609e4f5a26f27b510e46557345
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm...IMO, I think running doctests should be a separate build entirely from linting. They are two semantically different things, and the separation would allow us to provide more semantically clear display names such as "Doctests" and "Linting" instead of the slightly vaguer mashup of "Checks_and_doc".
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see there was a concern about not having to use an extra build for this due to resource constraints (the conversation is a very long in this PR...)? However, I'm not sure I fully understand...
Also, based on the conversation, are the
masterdocs no longer being published on https://pandas-docs.github.io/pandas-docs-travis? In which case, we need to update theGITHUB_ISSUEtemplate that we have here.